Skip to content

Rework signature parser to handle signature of generic types #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

Rework signature parser to handle signature of generic types #3213

merged 1 commit into from
Sep 24, 2025

Conversation

@josesimoes
Copy link
Member

@josesimoes josesimoes commented Sep 24, 2025 •
edited
Loading

Description

  • IsGeneric element is now part of element, not parser.
  • Generic argumetn count is not also part of element.
  • Update code accordingly.
  • Advance() now sets these new elements and adjusts parameter counter.
  • Update MatchSignatureElement to match these improvements and remove dead code.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Sep 24, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 24, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@josesimoes josesimoes force-pushed the rework-signature-parser branch from c3193d9 to 3b7505b Compare September 24, 2025 14:02
@josesimoes
Rework signature parser to handle signature of generic types
2aee79c 
- IsGeneric element is now part of element, not parser.
- Generic argumetn count is not also part of element.
- Update code accordingly.
- Advance() now sets these new elements and adjusts parameter counter.
- Update MatchSignatureElement to match these improvements and remove dead code.
@josesimoes josesimoes force-pushed the rework-signature-parser branch from 3b7505b to 2aee79c Compare September 24, 2025 14:16
@josesimoes
Copy link
Member Author

josesimoes commented Sep 24, 2025

Failing on updated mscorlib declaration. Merging anyway.

@josesimoes josesimoes merged commit a80f620 into nanoframework:develop Sep 24, 2025
23 of 25 checks passed
@josesimoes josesimoes deleted the rework-signature-parser branch September 24, 2025 15:11
@josesimoes josesimoes mentioned this pull request Sep 25, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Area: Common libs Everything related with common libraries Breaking-change Type: enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josesimoes @nfbot